Conversation
takaswie

Takashi Sakamoto (坂本 貴史)

https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git/tree/drivers/firewire/core-topology.c?h=v6.16#n263

```
235 list_for_each_entry(node, &list, link) {
...
245 list_add_tail(&child->link, &list);
248 ...
249 }
```

Oops...
1
0
0
wagi@mastodon.social

LostConnection

Reply to @takaswie

@takaswie

It is very easy to get things wrong with the list API. My favorite property is that the list_add arguments can be swapped and the compiler doesn't complain at all. It even works as long you have only one element at the time...

1
0
0
takaswie

Takashi Sakamoto (坂本 貴史)

Reply to @wagi@mastodon.social
Edited 23 days ago
@wagi

I think that one of solutions is to make flat list of fw_node. In IEEE 1394 specification, a bus can hold nodes up to 63. We can use 512 bytes kernel stack to keep pointers to the nodes, then release these references.
0
0
1
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: