Conversation
ljs@mastodonapp.uk

Lorenzo Stoakes

It's quite sobering realising a lot of shit code you see in mm exists because we just took it without _ANY_ review tags.

Joke.

3
0
0
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @ljs@mastodonapp.uk

IOW - no sign off. Review may have happened up to a point, but it stopped.

And that was taken as a 'merge this' signal.

Unreal.

1
0
0
ffmancera@mastodon.social

Fernando F. Mancera

Reply to @ljs@mastodonapp.uk

@ljs How is that? Shouldn't some maintainer sign it off and send it to Linus on a PR?

1
0
0
vitaut@mastodon.social

vitaut 🤍❤️🤍 🇺🇦

Reply to @ljs@mastodonapp.uk

@ljs one weird trick to become a kernel developer

0
0
0
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @ffmancera@mastodon.social

@ffmancera not if your maintainer is just merging anything.

1
0
0
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @ljs@mastodonapp.uk

@ffmancera in mm we have real maintainers and the guy who is taking everything and sending to Linus, they're not the same.

2
0
0
ffmancera@mastodon.social

Fernando F. Mancera

Reply to @ljs@mastodonapp.uk

@ljs :/

0
0
0
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @ljs@mastodonapp.uk

@ffmancera am working on trying to change this :)

0
0
0
kdave

kdave

Reply to @ljs@mastodonapp.uk
@ljs The most absurd thing I've heared in that regard was: sometimes I "threaten" that I'll merge something if people don't review it.
1
0
3
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @kdave

@kdave sigh. But no tags required.

Review is 'people replied until they stopped replying at which point I just take it'.

Yeah things have got to change...

1
0
0
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @ljs@mastodonapp.uk

@kdave btw you can REALLY TELL who was relying on this prior to the great 'mm now actually has maintainers' change.

And there's tantrums...

0
0
1
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: