Conversation
jstultz@hachyderm.io

John Stultz

@monsieuricon

Someone new to kernel development recently asked how to find review discussion on an upstream patch. And my/other's answer was "search lore for the commit subject", which is a little fussy, and may not help if the subject changed through the reviews.

After the recent Link: tag debate (https://lwn.net/Articles/1037069/), I was thinking if a commit hook was added to insert a Link: tag to a lore query with a sha-like value, one might be able to track all the discussion around a patch's revisions. This seems like it would potentially address Linus' complaint of the commonly used link to the last submission being uninteresting as that's not where the discussion is.

Now, this is obviously similar to Change-Id: tags, so I'd understand the hesitancy, but the hope is it would be immediately useful to everyone rather than Gerrit specific noise.

Has this idea already been considered/shot down?

2
0
0
jstultz@hachyderm.io

John Stultz

Reply to @jstultz@hachyderm.io

@monsieuricon

Maybe answering my own question, looks like Doug sort of had a similar-ish idea, which may be got derailed by the uuid aspect of his suggestion:

https://lore.kernel.org/all/CAD=FV=XGySHprMN+dv6dDKmuTQXnmYg5NStyaOJg+KdNUOFZsQ@mail.gmail.com/

0
0
0
monsieuricon

K. Ryabitsev-Prime 🍁

Reply to @jstultz@hachyderm.io
@jstultz if it's a patch that is already a commit, you can use "b4 dig" to get all possible information about it, including all revisions we can find. If it's not a commit yet, then we don't currently have a good mechanism to find its history other than what you suggest.
0
0
2
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: