@marcan @ljs I feel a bit called out (maybe I'm wrong) as I've been saying that "I learned to enjoy the struggle" and that I tend to enforce nitpicking comments (the "reverse xmas tree nonsense") particularly on newcomers these days.
Let me clarify again that I don't consider myself any sort of abusive masochist (is this even a thing in English?) which likes to put people through the pains he suffered, but the two things are strictly related to the end quality of the code that it is merged and how.
- clunky process make sure you check every part and make sure you know and think about what you're sending out and to who (and I still make a mistakes, so I know it's not all good). That said, I concur that a git push -f over the whole "format, edit cover letter, add receivers in" etc is simpler, even more for simple fixups. I don't see this happening easily though. In the subsystem I work the most there are at least 4 sub-maintainers maintaining their own trees and to get to a point where you can git push to a single tree it will take time to re-organize the whole subsystem workflow (not saying it's not possible, what I'm saying is that it's not a purely technical problem).
- nitpicking, even on style details, is for the sole sake of consistency of the code base. Some reviewers are annoying, some other try to phrase it in a way that sounds like a kinds suggestion, and I'm aware of the usual caveat of per-subsystem unwritten rules and personal preferences, which should be better handled I agree. You're free to use a styler if you like, nobody requires you to do so by hand so I don't get all this emphasis on "I'm gonna use clang-format for my subsystem", you're welcome to do so and everyone has her own formatting tools in place already (in the editor, in commit-hooks whatever). As others like
@sailus pointed out, once you let a driver diverge (style wise) you will soon get other submitters copying whatever is there and confront review comments with "I copied it from xyz, why is fine for others but not me?". Most comments here do not seem to consider this a problem at all and I suspect there's an underestimation of how bad things could go when thousands (ok, maybe hundreds if you consider a big sub-system like media) of people messes with the same code base.
Again, thanks for bringing this up, but please stop the "us" versus "them" thing though.