Conversation
gregkh

Greg K-H

Sasha's "AUTOSEL" logic has been revamped and published so that now you too, can dig in the Linux kernel commit logs to find patches that developers and maintainers forgot to tag to be backported to stable kernels:

The announcement:
https://lore.kernel.org/all/aBj_SEgFTXfrPVuj@lappy/

And the code itself:
https://git.sr.ht/~sashal/autosel
1
5
20
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @gregkh

@gregkh *perhaps forgot to tag. 100% of my series AUTOSEL'd were pointless, so a little humility might go a long way here.

1
0
0
gregkh

Greg K-H

Reply to @ljs@mastodonapp.uk
@ljs If you don't want stuff picked up by AUTOSEL, let us know and you can be added to the regex of files / directories to ignore. Many subsystems do as they do properly tag stuff. But for all the others, that's why AUTOSEL is there.
1
0
1
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @gregkh

@gregkh with respect Greg, this response bears no resemblance to what I said?

1
0
0
gregkh

Greg K-H

Reply to @ljs@mastodonapp.uk
@ljs I'm confused, AUTOSEL is there to pick up stuff that people don't tag that look like other bug fixes, it was created because many subsystems/maintainers do NOT tag anything, so this is needed to get those fixes.

For subsystems/authors that do properly tag them, and don't want to get picked up by AUTOSEL, let us know and they can be added to the list not to.

I thought that is what you were referring to here, if not, then I think it's time to just discuss it over beers in person :)
1
0
0
ljs@mastodonapp.uk

Lorenzo Stoakes

Reply to @gregkh
Edited 3 days ago

@gregkh more than happy to discuss over beers in person :) it's always my preference... text as a medium sucks...

All I'm saying is AUTOSEL is imperfect (I have no doubt you nor Sasha would say otherwise), so the phrasing 'developers + maintainers forgot to tag' comes off as pretty harsh and a little humility there would help.

I'm referring to a series (yes 100% is 1 series, but there we go ;) where I made changes in a subsystem other than mm which I can't control nor influence like that.

It's not actually a problem, the AUTOSEL'd patches are not _wrong_ they are just kinda pointless, but fine, which is why I didn't comment on them.

We had a discussion when I had my s.k.o account wherein I sympathised with your position on AUTOSEL (herding cats etc.)

Though personally I feel like it's a process problem that would be better solved by slapping maintainers who fail to follow it with a damp haddock... and THAT I am more than happy to discuss over beers :>)

0
0
0
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: