@brauner ah yes, that's this thing called "upstreaming" 😅

@brauner I would NACK it, clearly not enough RBs.

@brauner needs more co-developed-by

@brauner Reminds me AMD - Acked-by + 3x SoB + Tested-by for bump in a version string in header.

@brauner wondering if there is some law similar to Conway's law here somewhere. Something like:

"The higher the number of git footer tags from members of the same company in a patch-submission, the lower the education and trust the company puts into its open source developers".

Hmmm. Not sure if that fits. but I guess you get the idea.

https://en.wikipedia.org/wiki/Conway%27s_law

@brauner is that an acceptable way to do things?

@f4grx It's not wrong per se. If you have a bunch of people working in-house on a series then having a bunch of SoBs or CdBs (Co-developed-by) is not uncommon.

But if you then start having a bunch of RvBs/Acks from the same company as well it starts looking iffy.

It doesn't have to mean that the patchset is bad or that it's rejected but any experienced maintainer will be careful.

The example behind this is weird because the series is at a very high revision and so far no meaningful Acks/RvBs.

@brauner I am not a maintainer per se, but I have some interest in the development of the NuttX RTOS, and seeing too many code pushed by a single company always feel very uncomfortable. Did anyone else look at this? Is this sufficiently and honeslty tested? Are they tring to force contribute something? Even more so when it's about the locking infrastructure or some code with breakage potential.

@brauner and much thanks and respect for your important maintainer position.

@brauner @f4grx Get to know the humans. Then, decide if you trust the review. Multiple tags can mean more experienced developers are reviewing and coaching, and that's always a good thing. Trust comes first, though.

@brauner I got a new stamp with an expiry date. Who wants a RB, SoB... You get one anyway 😁

Reminds me another big corp, which had seemingly 3+ managers in the SoB chain, where the last one joined GH only to submit the PR. Their developer was on GH for years...