Conversation
Jarkko Sakkinen
jarkko
I guess I just follow the lead :D
❯ find -name json_writer.c
./tools/testing/selftests/container/json_writer.c
./tools/testing/selftests/bpf/json_writer.c
./tools/bpf/bpftool/json_writer.c
./tools/net/ynl/ynltool/json_writer.c
Maybe we should have shared json_writer.h/c for selftests?
❯ find -name json_writer.c
./tools/testing/selftests/container/json_writer.c
./tools/testing/selftests/bpf/json_writer.c
./tools/bpf/bpftool/json_writer.c
./tools/net/ynl/ynltool/json_writer.c
Maybe we should have shared json_writer.h/c for selftests?
1
0
0
@penguin42 I have absolutely have no idea and blindly just copied one from bpftool ;-)
1
0
0
penguin42
penguin42@mastodon.org.uk@jarkko
6b19ef2bc2f76002739a8f4984d20f8b ./tools/bpf/bpftool/json_writer.c
6b19ef2bc2f76002739a8f4984d20f8b ./tools/testing/selftests/bpf/json_writer.c
5a536dfff051935fabcef82e71e76460 ./tools/net/ynl/ynltool/json_writer.c
hehe....
1
0
1
Jarkko Sakkinen
jarkko
@penguin42 I can put a remark before diffstat to my kselftest patch and on request can consolidate them.
1
0
0
penguin42
penguin42@mastodon.org.uk@jarkko Oh I wasn't asking you to do anything; I was just finding the normal fun of how things get copied and then just gently change in fun ways later.
1
0
0
Jarkko Sakkinen
jarkko
@penguin42 Ya, got it. I just put a reminder for myself :-) It's good to point this out.
1
0
1
0
0
1