@marcan @Conan_Kudo @jacksonchen666 @monsieuricon I'm not sure I know how to quote your post, by trying by points:
- the nitpicking non-sense: I completely disagree here :) code is maintainable if its consistent, and code is consistent if rules are enforced, including reverse xmas-tree nonsenses :) (I got grumpy the first time I've been told to change a patch to adhere to that rule. Now I (kindly) ask people to comply with that especially newcomers). This doesn't mean that a well styled but bad engineered piece of code is acceptable of course. But form is substance when roughly a few thousand people are messing with the same code repository at the same time.
- the argument that "perfection is the enemy of good" stands, I see your point and I've recently dealt with a community that would have a lot of code to upstream but simply don't want to go through that struggle as they don't see the effort justified. This isn't good for anyone, but I feel the culprit is maybe in the downstream development process. Upstreaming should be planned early, budgeted (in time and funds) accordingly, and should be clear that you're putting yourself forward for future maintainership and you are willing to help the community with reviews of other people's code. If those conditions are not met, for whatever reason, it's better to have that code downstream otherwise someone will have to maintain it on your behalf. Might sound harsh, but maybe lowering the bar would make it easier to "merge and forget" and put additional burden on the community without giving anything back ?
By the way, these are all questions I'm asking myself as well, I got very sad by the recent push-backs I've received when I suggested to upstream that code I mentioned and the message I got back was along the lines of "hell no, I'm not going to spend time moving comment lines around to satisfy your OCD, as my code works already" (surprise surprise, it works for that single use case but not for others, if they would have upstreamed they would have known :)
Thanks for the discussion though