Conversation
dos@librem.one

Sebastian Krzyszkowiak

I have published the snippet of code that implements a GPU-based ISP with bunch of corrections and encodes video in real time on the Librem 5. Feel free to take parts of it and use in your apps and frameworks... or record your cats 😼

https://source.puri.sm/-/snippets/1223

3
4
1
pavel

Pavel Machek

Reply to @dos@librem.one
@dos Thank you! Viewfinder is upside down for me, and it has tendency to crash the camera (or system) as described in the README. I do not see crashes with my code (https://gitlab.com/tui/tui/-/tree/master/icam?ref_type=heads), but I'm doing _way_ simpler processing; I did see memory corruption with my version at one point, through. I'm using YUY2, and 1024x... 30fps recording is feasible with simple shaders.
1
0
0
dos@librem.one

Sebastian Krzyszkowiak

Reply to @pavel

@pavel It shows the right way and runs reliably for hours here on crimson. There should be no crashes whatsoever. Could be some regression on GStreamer side, but on newer distros you should rather use GTK4 and GtkGraphicsOffload instead anyway.

Of course simpler shaders allow for higher performance, the challenge is in simplifying the shader without making the output shitty ;)

2
0
1
dos@librem.one

Sebastian Krzyszkowiak

Reply to @dos@librem.one

@pavel ...and remember that it won't work on byzantium/bullseye.

0
0
0
pavel

Pavel Machek

Reply to @dos@librem.one
@dos For the record, I'm on Mobian 13 aka Trixie. I did single-bit change to get the viewfinder right side up. I'll play some more.

- "! gtkwaylandsink name=gtkwaylandsink rotate-method=1 sync=false "
+ "! gtkwaylandsink name=gtkwaylandsink rotate-method=3 sync=false "
1
0
0
dos@librem.one

Sebastian Krzyszkowiak

Reply to @pavel

@pavel rotate-method sets what gets passed to wl_surface::set_buffer_transform verbatim, and the camera is rotated 90° counter clock-wise in relation to the screen, so it should be 1. Unless I'm getting something wrong, it smells like a bug in newer phoc.

1
0
1
dos@librem.one

Sebastian Krzyszkowiak

Reply to @dos@librem.one

By the way, with just a one-line change (commenting out mp4mux/filesink, uncommenting flvmux/rtmpsink and adjusting the URL) you can stream online rather than to a local file 😎

(fwiw this screenshot is from before autofocus, white balance and most of image processing stuff was there)

0
1
0
Blort@social.tchncs.de

Blort™ 🐀Ⓥ🥋☣️

Reply to @dos@librem.one

@dos

Ladies, gentlemen and enbies of the Fedi... the circle is now complete. We have mobile Linux cat videos on The Fediverse.

0
2
0
pavel

Pavel Machek

Reply to @dos@librem.one
@dos I tried to add gtk buttons to trigger taking photo and to refocus... I failed so far. gstreamer + gtk behaves strangely.

Some time ago you mentioned you had phase-detection AF. Is that code somewhere? I understand it needs kernel changes.
0
0
0
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: