Conversation
krzk

Krzysztof Kozlowski

Edited 1 year ago

Once you see it, you cannot unsee:

+#ifndef MSM_VIDC_EMPTY_BRACE
+#define MSM_VIDC_EMPTY_BRACE {},
+#endif
...
+static const struct of_device_id msm_vidc_dt_match[] = {
+	{.compatible = "..."},
...
+	MSM_VIDC_EMPTY_BRACE
+};

We are back to the past! To year 2000-something to be precise. This reminds me ARM Mali Linux kernel drivers which were using MALI_SUCCESS instead of return 0.

1
0
5
Andi

Andi

Reply to @krzk
@krzk This looks cool... but this is even better:

#ifndef SEMICOLON
#define SEMICOLON ;
#endif /* SEMICOLON */
...
pr_info("something\n")SEMICOLON
...
1
0
1
krzk

Krzysztof Kozlowski

Reply to @Andi
@Andi Human creativity is endless.
0
0
0
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: