Conversation
@pdp7 The multiple "---" is a pretty normal way to split out the bits to keep post git-am.
1
0
1
@pdp7 @conor git-am is smart enough to handle post-"---" comments in single patches, I do that all the time when I have just something small to say that doesn't really warrant a cover letter.

I'd just stick with whatever b4-send does, as it'll be understood by b4-shazam and that's the most canonical way to merge things these days.
0
0
1
@pdp7 @palmer Having the best-regards stuff after a --- probably makes life easier for the person doing `b4 shazam` on the other end, especially if they do it in the way that creates a merge commit from the cover (-M or -H).
1
0
2
@pdp7 @palmer If you don't like the template being there, you can always write a b4-cover-template file & point to it with `b4.prep-cover-template` in your git config (see https://b4.docs.kernel.org/en/latest/config.html#contributor-settings).
The default is:
```
${cover}

---
${shortlog}

${diffstat}
---
base-commit: ${base_commit}
change-id: ${change_id}

Best regards,
--
${signature}
```
1
0
1
@pdp7 @conor Just make sure not to mix up "--" and "---" ;)
1
0
1
@pdp7 @conor Not as far as I know, everything in the "[]" is just for humans.
0
0
1
@pdp7 we do use "---" as a way to find the changelog section. Unfortunately.
0
0
1