Conversation
hyeyoo

Hyeonggon Yoo

Unintentionally messed up @vbabka 's tree tree by doing last-minute reviews :(
1
0
2
vbabka

Vlastimil Babka

Reply to @hyeyoo
@hyeyoo haha don't worry it's my fault, I have broken your patch by a stupid cleanup, you told me about it, I've fixed it up on the laptop but the broken version stayed on my desktop.
I've now also realized why git diff @{u} didn't show that I'm pushing unintended changes.
Because I didn't even fetch the remote first.

git hard, me dumb

*SHRIEK*

🎶I've pushed the sheriff
but I didn't fetch the deputy🎶

*brachiates into the fields to frolick there joyously*
2
0
2
lkundrak@metalhead.club

HAMMER SMASHED FILESYSTEM 🇺🇦

Reply to @vbabka

@vbabka @hyeyoo got to confess i'm always a little bit suspicious when a mm/ person says "my fault" tbh *shriek* *shriek* 🐔

1
0
2
vbabka

Vlastimil Babka

Reply to @vbabka
@hyeyoo that said, my git ineptitude probably doesn't explain the "sysfs: cannot create duplicate filename '/kernel/slab/:a-0000176'" messages, only the fallout from them. Wonder what's going on there.
1
0
0
hyeyoo

Hyeonggon Yoo

Reply to @vbabka
@vbabka Is that caused only after applying the patch? Or has it been like that before?
1
0
1
vbabka

Vlastimil Babka

Reply to @hyeyoo
@hyeyoo oh right, it's probably also because of the bug too. When we return -EINVAL from do_kmem_cache_create() because of the bug, the sysfs directory stays, so another attempt with the same size+attributes results in a duplicate
0
0
1
liskin@genserver.social

Tomáš Janoušek

Reply to @lkundrak@metalhead.club
@lkundrak @vbabka @hyeyoo Faults don't have owners. Should be "my userfaultfd"
1
1
2
vbabka

Vlastimil Babka

Reply to @liskin@genserver.social
@liskin @lkundrak @hyeyoo no that one can't be my (or yours) as it ends with a "d", so it's inevitably systemd-userfaultfd
0
0
1
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: