Conversation
krzk

Krzysztof Kozlowski

Edited 4 days ago
I sent a simple, yet not the shortest, DT bindings patch for the Linux kernel. I got five review tags in response, for which I thank you, however three (60%) of them where in format:

> My commit msg...
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Mr. Foo

> here goes
> my ...
> entire patch
> for su knows how long.
> Really long!

I was complaining about this on the lists already. I am not going to, heh, no one should be to, scroll through entire message to check whether there was something after that Reviewed-by tag. Or after comment.

Knowing that it is trivial to remove unneeded context (see below), I find that just disrespectful to me and my time.

I am going to ignore EVERYTHING from something which looks like end of message. if you put there something, your problem.

E.g. if one uses mutt and vim - that's part of your alias:
```
nmap <silent> <leader>A :.,$d<CR>A<CR><CR>Acked-by: Krzysztof Kozlowski <krzk@kernel.org><CR><CR>Best regards,<CR>Krzysztof<CR><ESC>
```
1
0
2
krzk

Krzysztof Kozlowski

Reply to @krzk
Therefore special thanks for Geert and Rob who did trim their replies - they end with Reviewed-by tag. :)
1
1
3
geert@society.oftrolls.com

Geert Uytterhoeven

Reply to @krzk

@krzk You're welcome! ;-)

I feel your pain: it is very hard to find all review comments in untrimmed email. So please always trim your emails when replying.

Thanks!

0
1
1
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: