Conversation
Krzysztof Kozlowski
krzk
Edited 6 days ago
I sent a simple, yet not the shortest, DT bindings patch for the Linux kernel. I got five review tags in response, for which I thank you, however three (60%) of them where in format:
> My commit msg...
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Mr. Foo
> here goes
> my ...
> entire patch
> for su knows how long.
> Really long!
I was complaining about this on the lists already. I am not going to, heh, no one should be to, scroll through entire message to check whether there was something after that Reviewed-by tag. Or after comment.
Knowing that it is trivial to remove unneeded context (see below), I find that just disrespectful to me and my time.
I am going to ignore EVERYTHING from something which looks like end of message. if you put there something, your problem.
E.g. if one uses mutt and vim - that's part of your alias:
```
nmap <silent> <leader>A :.,$d<CR>A<CR><CR>Acked-by: Krzysztof Kozlowski <krzk@kernel.org><CR><CR>Best regards,<CR>Krzysztof<CR><ESC>
```
> My commit msg...
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Mr. Foo
> here goes
> my ...
> entire patch
> for su knows how long.
> Really long!
I was complaining about this on the lists already. I am not going to, heh, no one should be to, scroll through entire message to check whether there was something after that Reviewed-by tag. Or after comment.
Knowing that it is trivial to remove unneeded context (see below), I find that just disrespectful to me and my time.
I am going to ignore EVERYTHING from something which looks like end of message. if you put there something, your problem.
E.g. if one uses mutt and vim - that's part of your alias:
```
nmap <silent> <leader>A :.,$d<CR>A<CR><CR>Acked-by: Krzysztof Kozlowski <krzk@kernel.org><CR><CR>Best regards,<CR>Krzysztof<CR><ESC>
```
1
0
2
Geert Uytterhoeven
geert@society.oftrolls.com@krzk You're welcome! ;-)
I feel your pain: it is very hard to find all review comments in untrimmed email. So please always trim your emails when replying.
Thanks!
1
1
1
Krzysztof Kozlowski
krzk
@Conan_Kudo @geert Review under commit msg is the review of everything. Don't ask people to scroll through hundreds of lines just to figure out that they do not need to even scroll! (because b4 will collect the tag, but they had to be sure not to miss any feedback).
As I said, this is is disrespectful to me, this is wasting my time. The way to recover my time is to just ignore such emails.
As I said, this is is disrespectful to me, this is wasting my time. The way to recover my time is to just ignore such emails.
1
0
0
Geert Uytterhoeven
geert@society.oftrolls.com@Conan_Kudo @krzk By providing your "Reviewed-by:"-tag without any further comments, you indicate that you reviewed the patch (or patch series) in the email referenced by the "In-Reply-To:"-header in your email response.
How much you quote is irrelevant for the validity of the tag. But it does have an impact on the productivity of the patch submitter, the subsystem maintainer, and other reviewers.
0
0
0
Krzysztof Kozlowski
krzk
@Conan_Kudo Well, your opinion here is contradictory to Linux kernel process. It's clear here:
> By offering my Reviewed-by: tag, I state that:
> (a) I have carried out a technical review of this patch to
> evaluate its appropriateness and readiness for inclusion into
> the mainline kernel.
Nowhere, nowhere in the Linux kernel process is any mention that the tag placement matters and suggesting that it does not only contradicts practice of all reviewers and maintainers but it makes no sense. It just creates noise and additional effort on receivers of your email.
> By offering my Reviewed-by: tag, I state that:
> (a) I have carried out a technical review of this patch to
> evaluate its appropriateness and readiness for inclusion into
> the mainline kernel.
Nowhere, nowhere in the Linux kernel process is any mention that the tag placement matters and suggesting that it does not only contradicts practice of all reviewers and maintainers but it makes no sense. It just creates noise and additional effort on receivers of your email.
0
0
0
Krzysztof Kozlowski
krzk
@Conan_Kudo @geert Plus, your tags given to cover letters suggest - following your logic - that you only reviewed cover letter and you did not read the patches at all.
1
0
0