Conversation
monsieuricon

K. Ryabitsev

Reply to
@lina I'm happy to receive any b4 feedback you have. The "#" treatment bit is really because the cover letter is a git commit and if you edit it directly with git, it will remove any lines starting with "#". I'm worried that if we treat these any differently, we'll potentially run into unexpected behaviour. :/
1
0
4
monsieuricon

K. Ryabitsev

Reply to
@lina It's not "accidentally" if they literally asked to be cc'd on that regex. :)
0
0
3
monsieuricon

K. Ryabitsev

Reply to
@lina my goal is to avoid unexpected behaviour, so I'll try to think of a way that would both allow someone to add comments that won't go into the final cover letter (such as commenting out a Cc trailer) and do markup.
1
0
1
monsieuricon

K. Ryabitsev

Reply to
@lina I am considering using ">#" that is converted to just "#" when put into the cover letter body, but that's a partial fix. You'd still hit this same problem if you didn't know to use "># header" syntax. However maybe if I add this into the default cover letter template, it will be more obvious.
1
0
0
palmer

Palmer Dabbelt

Reply to @monsieuricon
@monsieuricon @lina Not sure if there's a thread, I can't find it on lore.

Is this a git-ism? If not I think we should propose it as, I recently almost got bit by a "#" that just happened to line-break to the first character of a commit message. I escaped it with a space, but that's a bit ugly.
1
0
0
monsieuricon

K. Ryabitsev

Reply to @palmer
@palmer @lina Yes, git has always stripped lines starting with # -- which is why it's the behaviour in b4 as well.
1
0
0
palmer

Palmer Dabbelt

Reply to @monsieuricon
@monsieuricon @lina Sorry, I was trying to ask if the ">#" escaping can be done elsewhere in git, as otherwise I end up just having to re-word things to avoid "#" starting a line.
1
0
0
monsieuricon

K. Ryabitsev

Reply to @palmer
@palmer @lina No, the ">#" bit is something I just came up with today. :)
0
0
0
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: