Mew, first #rtw8723cs push in a while, just small changes requested in review.

There’s one larger change I still need to make before sending a v2 patch set: Parse PHY status for received packages using a struct instead of getting bits using macros (basically treating the raw u8* as a struct rtw8703b_phy_status* or similar). Other rtw88 chip drivers use the macro style but the maintainer wants to get rid of it, so the request not to add more code in that style is fair.

And then I need to figure out the right order for Signed-off-by, Tested-by, and Acked-by entries people have offered.

@airtower You should not be getting signd-off-by's from people. That's for maintainers. If you simply put tested-by and acked-by entries before your sign-off, you should be fine. Their order should not matter much.

@pavel Right, I misremembered what a maintainer had written there. What confused me was that the docs describe the order for s-o-b in detail, but not for the other tags, and looking at examples in the logs the order seems to be all over the place.

@airtower @pavel `b4 trailers -u -F ....` and don't worry about any orders or forgotten tags.

@krzk @pavel Interesting, I hadn’t heard of b4 before (heh!), I’ll have to take a closer look at that after I finish the changes.

@airtower @pavel b4 simplifies entire workflow with Linux contributions and it also makes sure that in certain aspects it is correct, e.g. CC-ing proper people, applying tags, providing versioning. We keep repeating it all the time, that all new contributors should use it. I think also all new tutorials rely on b4...

@krzk @pavel That might need some work then, I didn’t see any mention of b4 in https://www.kernel.org/doc/html/latest/process/submitting-patches.html, or in https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches. Automatically filling CC would definitely be helpful, I used scripts/get_maintainer.pl and manually made a list from there.

@airtower @pavel These are documents describing rules and the contribution process. These are not tutorials and they have never been such. They do not mention tools at all, e.g. people submit/manage patchsets with quilt, git or whatever. That's why there is no place for b4 there. You can use any tools...

Tutorials are for example:
https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
https://www.youtube.com/watch?v=QBR06ml2YLQ&ab_channel=KonstantinRyabitsev
https://www.marcusfolkesson.se/blog/use-b4-for-kernel-contributions/
and others presented on conferences or on blogs...

Just sent out the v2 patchset for #rtw8723cs. Merge please, meow?

Mew, responded to review comments I got so far. Two minor changes, one explanation why I’d rather keep it that way (I don’t like if headers must be #included in particular order, and Clangd doesn’t either), and one question about related chips. So… Nothing major so far! #rtw8723cs

I’ve rebased my rtw88_8723cs and rtw88_8723cs-optimize branches on megi’s 6.8-rc6 variant, plus equally rebased @postmarketOS patches (it looks like they’ll be able to drop a few with 6.8). There was no need to change the #rtw8723cs patches otherwise. https://github.com/airtower-luna/linux/commits/rtw88_8723cs/

The biggest remaining issue is that the chip/firmware sticks to pretty low RX data rates with #rtw8723cs. I don’t know why yet, what I know is that the firmware handles rate negotiation, but also uses some information from the driver to do that (e.g. the driver sends EVM average to the firmware via H2C messages). My current guess is that something RTL8703B needs doesn’t match what the generic rtw88 infrastructure does, but that’ll need more research.

Sent out v3 of the initial #rtw8723cs patch set. The changes from v2 are minor and exactly as requested in review, so I hope it's good to merge now. ​​ https://lore.kernel.org/linux-wireless/20240309115650.367204-1-fiona.klute@gmx.de/T/

And now there’s #rtw8723cs v4 with one minor (reasonable) change, and I rebased my Git branches on megi’s v6.8 tree. When it gets merged rebasing any further work will get so much easier…

For anyone using the rtw88_8723cs-optimize branch, note that it now also includes a few patches for the old 8723cs driver. One of them is required to build it with LLVM, the others just get rid of some warnings.

#rtw8723cs is now on wireless-next, merged just a few minutes ago! Yaaaay! ​​ 🎉 https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/log/

@airtower Congratulations, and looking forward to 6.10 :-).

@airtower Congratulations! That's a huge step forward for mainline on the PinePhone. I'm really excited for linux 6.10!