Conversation
krzk

Krzysztof Kozlowski

Edited 1 year ago

@conor @palmer With just two fixes in kernel RISC-V DTS have full dtbs_check compliance! Good job RISC-V folks!

  DTC_CHK arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb
  DTC_CHK arch/riscv/boot/dts/allwinner/sun20i-d1-dongshan-nezha-stu.dtb
  ...

[1] https://lore.kernel.org/linux-devicetree/20230326164751.104789-1-krzysztof.kozlowski@linaro.org/T/#u

[2] https://lore.kernel.org/linux-devicetree/20230326164700.104570-1-krzysztof.kozlowski@linaro.org/T/#u

1
1
2
conor

Conor Dooley

Reply to @krzk
@krzk @palmer For a while I had managed to get us down to zero!
I think that canaan one popped up as a result of Rob's unevaluated-properties fixes in dt-schema. I'll go pick up that fix later, thanks.
1
0
0
krzk

Krzysztof Kozlowski

Reply to @conor
@conor @palmer Indeed, new things will keep popping up. New bindings might get converted to DT schema, Rob might add more checks/warnings... or new DTS can introduce something. I think the only way to keep near-zero warnings is to keep running dtbs_check on new patches, so you spot new issues fast.
1
0
1
conor

Conor Dooley

Reply to @krzk
@krzk @palmer yup. I try to keep on top of it - I think the k210 stuff is in a bit of a blind spot as it's incompatible with defconfig due to its lack of an mmu.
1
0
0
palmer

Palmer Dabbelt

Reply to @conor
@conor @krzk also looks like whatever I was doing to check the tests is broken, there's some spew in the logs about `Documentation/devicetree/bindings/firmware/fsl,scu.example.dtb: system-controller: pinctrl:lpuart0grp:fsl,pins:0: [111, 0, 100663328, 112, 0, 100663328] is too long`
1
0
0
conor

Conor Dooley

Reply to @palmer
@palmer @krzk possibly your dt-schema is out of date. I usually try and keep up to date w/ dt-schema's main branch: https://github.com/devicetree-org/dt-schema#installing
1
0
0
palmer

Palmer Dabbelt

Reply to @conor
@conor @krzk that's probably it, but I'm still worried about why the tests aren't failing...
1
0
0
conor

Conor Dooley

Reply to @palmer
@palmer @krzk What do you use to determine if the test fails?
1
0
0
palmer

Palmer Dabbelt

Reply to @conor
@conor @krzk grep/bash/make type stuff, it's almost certainly broken ;)
2
0
0
krzk

Krzysztof Kozlowski

Reply to @palmer
@palmer @conor dtbs_check produces warnings thus it does not fail entire make command. Warnings are a bit non-standard, so for example for Buildbot I use "^.*\.dtb: " pattern to detect them.
0
0
1
conor

Conor Dooley

Reply to @palmer
@palmer @krzk The parsing doesn't look broken, but the exit status for the submake jobs are a) ignored for dt_binding_check (fair, I do that too in my CI) and b) afaik unaffected by dt-schema issues in dtbs_check
1
0
0
conor

Conor Dooley

Reply to @conor
@palmer @krzk Ohh, and W=1 for dtbs_check isn't too bad, there's one known issue w/ the renesas bits that's waiting on dma bits.
0
0
0
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: