Conor Dooley
Posts
507Following
144Followers
178I like cycling, powerlifting, bad video games and metal.
Otherwise, I occupy my time with various bits in RISC-V land.
~useless, placeholder, website: https://www.conchuod.ie/
@pdp7 Yup. https://github.com/neovim/nvim-lspconfig + clangd. s/clangd/rust-analyzer when I try to write Rust.
0
0
1
Conor Dooley
conor
The diagnostics from clangd really suffer from too many false positives. Mostly ends up getting ignored, even when it's right, as a result :/
0
0
1
@llvm @marcan So I did go watch https://www.youtube.com/watch?v=lzdpO3kyoE0 & it's not as bad as I expected it to be. The goal there does actually seem fairly aligned - making the experience less frustrating for contributors & maintainers.
But at the same time, yeah documenting differences is less helpful to contributors than dropping the differences altogether. And some of the stuff, like suggesting maintainers should document that they commit their own material without sending it out for review instead of just not doing it I would have to disagree with.
Hard subject to even attempt to stand up and make "directed" suggestions about at LPC though!
But at the same time, yeah documenting differences is less helpful to contributors than dropping the differences altogether. And some of the stuff, like suggesting maintainers should document that they commit their own material without sending it out for review instead of just not doing it I would have to disagree with.
Hard subject to even attempt to stand up and make "directed" suggestions about at LPC though!
0
0
1
@mupuf @sima @jani @ljs @marcan Right, I figured it was going to be some DRM thing.
Apart from arch code, where there are a bunch of people that do care given the obvious wide reach of changes, I've found that most subsystems that I pay attention do not have a "community" of developers to speak of & it is only those directly listed as maintainers who provide review - especially for new drivers etc.
Apart from arch code, where there are a bunch of people that do care given the obvious wide reach of changes, I've found that most subsystems that I pay attention do not have a "community" of developers to speak of & it is only those directly listed as maintainers who provide review - especially for new drivers etc.
0
0
2
@mupuf @ljs @marcan @jani
"Pinchart said that he always starts off a review by thanking the submitter for the patch and that he often offers a Reviewed-by tag if specific changes are made. That gives both a positive message and a hint of light at the end of the tunnel that can help new submitters."
Totally agree with Laurent on that one, especially if one is not an applier of patches for that code.
Interesting article, thanks for sharing.
"Pinchart said that he always starts off a review by thanking the submitter for the patch and that he often offers a Reviewed-by tag if specific changes are made. That gives both a positive message and a hint of light at the end of the tunnel that can help new submitters."
Totally agree with Laurent on that one, especially if one is not an applier of patches for that code.
Interesting article, thanks for sharing.
0
0
1