Posts
284
Following
88
Followers
3018
@xav it has only been a few hours, no idea how even a single day would work yet...
2
0
0
New hardware showed up today, turns out Linux works just fine on it. Here's the 6.12.1 kernel running in Wayland.

Water bottle for scale.
5
11
43
repeated

K. Ryabitsev šŸ

Yeah, so I may have been bored in a meeting today...

https://mirrors.kernel.org/bogus
8
11
28
@monsieuricon Oh great, of course now this means I need to write a hampster_fs kernel module and get it merged, yet another thing to add to my TODO list...
1
0
4
repeated

@ross If a distro is attempting to build and distribute a years-old version of XScreenSaver then it is my explicit goal to make life absolutely as difficult as possible for them.

3
1
0
repeated

In todayā€™s news: man with zero self reflection goes on lengthy one sided rant highlighting just that.

4
4
1
repeated

Thorsten Leemhuis (acct. 1/4)

6.12 is out. For a list of new features see:

* This short LWN story: https://lwn.net/Articles/997958/ (screenshotted)

* Two detailed stories from LWN: https://lwn.net/Articles/990750/ & https://lwn.net/Articles/991301/

* The kernelnewbies page: https://kernelnewbies.org/Linux_6.12

See also the announcement from @torvalds:

https://lore.kernel.org/lkml/CAHk-=wgtGkHshfvaAe_O2ntnFBH3EprNk1juieLmjcF2HBwBgQ@mail.gmail.com/

'"No strange surprises this last week, so we're sticking to the regular release schedule, and that obviously means that the merge window opens tomorrow."'

5
7
3

{sigh} Go home CodeQL, you are drunkā€¦

int main(int argc, char *argv[])
Poorly documented function: fewer than 2% comments for a function of 129 lines.

Code in question is at: https://github.com/gregkh/usbutils/blob/master/lsusb.c#L3835 if people are curious. Itā€™s as if the tool hasnā€™t seen C code beforeā€¦

2
9
17
To followup up on this, @xexaxo sent a pull request to get rid of these "code in the meson temp files are security issues" false-warnings: https://github.com/gregkh/usbutils/pull/211

Many thanks for this, now to whittle down the other pointless `switch case is too big` and `FIXME is left in a comment` warnings that are left so that if anything "real" ever shows up, it will actually be noticed...
1
0
7
@xexaxo Yes, thank you! And thanks for the PR, I'll go merge that now and see how it goes.
0
0
2
@tbodt Nope, didn't work. Or I got the yaml wrong, which is probably the real reason here...
1
0
0
@tbodt Oh, nice, let me attempt that...
1
0
0
@tbodt codeql really wants to build the code, as I'm guessing it is doing so with a compiler hack to get at the files needed to analyze. I guess we can turn that off, let me try that out...
0
0
0
@tbodt @captainepoch Yes, enabling it is good. Stupid tests claiming problems that are not actually present at all are not good.

Drowns out any potential real issues.
2
0
0

As it turns out that ā€œcode scanningā€ isnā€™t public, hereā€™s the error message that github is putting up saying that meson temp build files are security problems:

build/meson-private/tmpzhj7u8eq/testfile.c:2  Test

Poor global variable name 'i'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).

Rule ID cpp/short-global-name

Description
This rule finds global variables which have a name of length three characters or less. It is particularly important to use descriptive names for global variables. Use of a clear naming convention for global variables helps document their use, avoids pollution of the namespace and reduces the risk of shadowing with local variables.
0
0
1
@captainepoch Ok, sorry about that. I'll respond to the original with the full error message...
0
0
0
@captainepoch Odd, works for me!

How about this https://github.com/gregkh/usbutils/security/code-scanning

And it's obviously picking up the temp files that meson uses for "does this compiler have this feature" but that's temp files, and not actually in the repo itself. Surely tools like meson are handled properly, right?
2
0
0
Dear lazyweb,

For the usbutils project, developers have helpfully set up a bunch of github actions to help with build tests and the like, and it also includes github's "security scanning" toolsets. Unfortunately the output of such tools is pretty useless and unhelpful to a fault.

Example, this "result": https://github.com/gregkh/usbutils/security/code-scanning/2291
which claims "short global name" yet there is no such actual global variable `i` in the codebase at all.

Because of stuff like this, the tools "claim" there are 63 "security" issues in the usbutils project. Since when did using single character names become a security issue, even if we were doing that, but ok...

So, how to turn this off, or better yet, fix the test to not report issues that are actually in the tests themselves?
4
6
12
Show older