Once you see it, you cannot unsee:
+#ifndef MSM_VIDC_EMPTY_BRACE
+#define MSM_VIDC_EMPTY_BRACE {},
+#endif
...
+static const struct of_device_id msm_vidc_dt_match[] = {
+ {.compatible = "..."},
...
+ MSM_VIDC_EMPTY_BRACE
+};
We are back to the past! To year 2000-something to be precise. This reminds me ARM Mali Linux kernel drivers which were using MALI_SUCCESS instead of return 0.
Cleanup of inactive maintainer entries is coming :) - docs: maintainer: document expectations of small time maintainers
@kernellogger @gregkh But you know, adding proper sysfs interface takes few more lines of code… and one has to write documentation… and then sysfs is counted as ABI, so one cannot freely change it… and long command lines look so readable, just consider this Android-related stuff added by bootloader for one SoC:
androidboot.verifiedbootstate=orange androidboot.keymaster=1 androidboot.vbmeta.device=PARTUUID=815a78c5-ebb4-48ec-2912-90eeb3f71c48 androidboot.vbmeta.avb_version=1.2 androidboot.vbmeta.device_state=unlocked androidboot.vbmeta.hash_alg=sha256 androidboot.vbmeta.size=12800 androidboot.vbmeta.digest=815a78c5fb66af47291265ab90eeb3f71c48c9af6ad65044a08a5d81e77299a1 androidboot.veritymode=enforcing androidboot.veritymode.managed=yes androidboot.bootdevice=1184000.ufs androidboot.fstab_suffix=default androidboot.boot_devices=soc/1184000.ufs androidboot.serialno=19111140 androidboot.mode=ffbm-00 quite androidboot.baseband=msm msm_drm.dsi_display0=qcom,mdss_dsi_vtdr6130_fhd_plus_cmd:config0:timing0: androidboot.force_normal_boot=1 silent_boot.mode=nonsilent
Isn’t it beautiful?
Go Beavers! I mean, the true beavers, the greatest ecosystem engineers, which are vital in bringing diversity, richness, and healing degraded landscapes. “Beaver settlements triple in 15 years in Switzerland” https://www.swissinfo.ch/eng/beavers-increase-threefold-in-15-years-in-switzerland/48657934
If you want to learn more, why beavers are important, I recommend Andrew Millison’s: https://youtu.be/43bmtqKDhBE