Conversation
jarkko

Jarkko Sakkinen

@ljs you got it, i did my fedora ark test (compile a random tip as distribution kernel) with a "random patch set".
1
0
0
jarkko

Jarkko Sakkinen

Reply to @jarkko
@ljs i guess it goes as a review by itself that i could understand the code changes despite somewhat alien subsystem internals (thus ack's). it's usually a good sign at least.
1
0
0
vbabka

Reply to @jarkko
@jarkko @ljs note it's nice when adding just acked-by/tested-by with no code comments to do it right under s-o-b and remove the code :) and when the comments are only to some parts of the code, also trim the nrelated ones. Please consider next time :) Thanks.
1
0
2
jarkko

Jarkko Sakkinen

Reply to @vbabka
Edited 26 days ago
@vbabka @ljs sure, i can do that. different subsystem have different expectations about everything so you cannot know without sending something, so if i don't put anything extensive, i do as little as possible and wait for suggestions like this.

i'm sure that my tags plus minor comments can still be relatively easily accessed but next time i'll follow the advice.

edit: lol put my signature into the comment (removed)
2
0
1
jarkko

Jarkko Sakkinen

Reply to @jarkko
@vbabka @ljs Like in some arch-tree's I've been asked not to use "we" but instead imperative passive in commit messages whereas in other subsystems that is perfectly fine.

"don't do before do, and then do following the feedback" is my "minimum rant heuristics" :-)
0
0
1
ljs

Reply to @jarkko
@jarkko @vbabka it was really hard for me to read, best to put it after signed-off esp with a ton of code like the tests!

Appreciate you (even accidentally) checking this + giving tags though. Glad it works for you also.
1
0
2
jarkko

Jarkko Sakkinen

Reply to @ljs
@ljs @vbabka ya keep this in mind, my language model has now been upgraded ;-)
0
0
1
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: