Conversation
gregkh

Greg K-H

Reply to
@kernellogger If wearing a shirt with that on it actually made a difference, I'm all for it, but odds are, the people who I need to say this to wouldn't see it...
1
0
6
gregkh

Greg K-H

Reply to
@jani @kernellogger Modifying the command line is hard, if not impossible, for almost everyone other than a developer. So for a developer, sure, use a module parameter for crazy debugging stuff. but NEVER ask a user to use it for a normal operation, or for something that you should be doing in a per-device way.
3
0
3
palmer

Palmer Dabbelt

Reply to @gregkh
@gregkh @jani @kernellogger I can barely manage to make module parameters work reliably, it certainly seems like a lost cause for users
0
0
0
krzk

Krzysztof Kozlowski

Reply to

@kernellogger @gregkh But you know, adding proper sysfs interface takes few more lines of code… and one has to write documentation… and then sysfs is counted as ABI, so one cannot freely change it… and long command lines look so readable, just consider this Android-related stuff added by bootloader for one SoC:

androidboot.verifiedbootstate=orange androidboot.keymaster=1 androidboot.vbmeta.device=PARTUUID=815a78c5-ebb4-48ec-2912-90eeb3f71c48 androidboot.vbmeta.avb_version=1.2 androidboot.vbmeta.device_state=unlocked androidboot.vbmeta.hash_alg=sha256 androidboot.vbmeta.size=12800 androidboot.vbmeta.digest=815a78c5fb66af47291265ab90eeb3f71c48c9af6ad65044a08a5d81e77299a1 androidboot.veritymode=enforcing androidboot.veritymode.managed=yes androidboot.bootdevice=1184000.ufs androidboot.fstab_suffix=default androidboot.boot_devices=soc/1184000.ufs androidboot.serialno=19111140 androidboot.mode=ffbm-00 quite androidboot.baseband=msm msm_drm.dsi_display0=qcom,mdss_dsi_vtdr6130_fhd_plus_cmd:config0:timing0: androidboot.force_normal_boot=1 silent_boot.mode=nonsilent

Isn’t it beautiful?

2
2
3
gregkh

Greg K-H

Reply to @krzk
@krzk @kernellogger Android devices do this as they do control the bootloader, and they control their individual drivers, BUT not the core kernel image/source. sysfs interfaces are forbidden by default by the SELinux rules and adding an exception for an Android device for them is a real pain (which is a good thing.) So they default to command line options as it's trivial to do that in a driver and for them, it works well (again, full control over the command line options.)

But that isn't an acceptable interface for upstream, for all the same reasons :)
0
0
2
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: