Conversation

K. Ryabitsev-Prime 🍁

Here's a prototype of "b4 review" with a nicer textual ui. What do you think?

https://asciinema.org/a/776900
2
1
8

@monsieuricon whenever a need to answer to a patchset from some time ago, what I usually did was to use the incredible hackermail (https://github.com/sjp38/hackermail/) from @sj , but I would say that this new feature from b4 is also amazing!

0
0
2

@monsieuricon

For me, the thing about emailed patches and review is that I can use the mail client I like. (I write code in emacs, I write email in emacs, etc.)

I also like b4, a lot. I love being able to pipe a message from emacs to 'b4 shazam'.

There's just no way I'm going to use the presented 'b4 review'. That's not to say I think it's either good or bad, just that as-is it doesn't fit my workflow.

I am curious what non-interactive features it might have that could benefit my workflow.

1
0
0
@jani if you are happy with your workflow, then I obviously don't want to interfere with it. However, I'm hoping this will help others, plus it can integrate with agent-assisted reviews (not yet done).
1
0
1

@monsieuricon

I'm trying (and failing) to say I see value here, even if as-is it doesn't look compatible with my workflow. They are two separate things.

Now, I'm always looking for ways to improve my workflow, and I'm wondering what parts of this could be used in a scripted, non-interactive way to integrate into my workflow.

0
0
0