Conversation
monsieuricon

K. Ryabitsev-Prime 🍁

Here's a prototype of "b4 review" with a nicer textual ui. What do you think?

https://asciinema.org/a/776900
3
3
14
mpdesouza@floss.social

Marcos Paulo de Souza

Reply to @monsieuricon

@monsieuricon whenever a need to answer to a patchset from some time ago, what I usually did was to use the incredible hackermail (https://github.com/sjp38/hackermail/) from @sj , but I would say that this new feature from b4 is also amazing!

0
0
2
jani@floss.social

Jani Nikula

Reply to @monsieuricon

@monsieuricon

For me, the thing about emailed patches and review is that I can use the mail client I like. (I write code in emacs, I write email in emacs, etc.)

I also like b4, a lot. I love being able to pipe a message from emacs to 'b4 shazam'.

There's just no way I'm going to use the presented 'b4 review'. That's not to say I think it's either good or bad, just that as-is it doesn't fit my workflow.

I am curious what non-interactive features it might have that could benefit my workflow.

1
0
0
monsieuricon

K. Ryabitsev-Prime 🍁

Reply to @jani@floss.social
@jani if you are happy with your workflow, then I obviously don't want to interfere with it. However, I'm hoping this will help others, plus it can integrate with agent-assisted reviews (not yet done).
1
0
1
jani@floss.social

Jani Nikula

Reply to @monsieuricon

@monsieuricon

I'm trying (and failing) to say I see value here, even if as-is it doesn't look compatible with my workflow. They are two separate things.

Now, I'm always looking for ways to improve my workflow, and I'm wondering what parts of this could be used in a scripted, non-interactive way to integrate into my workflow.

0
0
0
mpdesouza@floss.social

Marcos Paulo de Souza

Reply to @monsieuricon

@monsieuricon Any ideas when this feature will be available? :)

1
0
0
monsieuricon

K. Ryabitsev-Prime 🍁

Reply to @mpdesouza@floss.social
@mpdesouza I just need to complete a few steps that would let maintainers "take" the series as opposed to just review it. Not far now, I just need to a) recover from being sick, b) stop dealing with failing hardware. ;)
1
0
0
mpdesouza@floss.social

Marcos Paulo de Souza

Reply to @monsieuricon

@monsieuricon I'm currently reviewing a patchset by replying to each email, and I remembered that B4 would do it in a better way...
Thanks for the update!

1
0
0
sj

sj

Reply to @mpdesouza@floss.social
Edited 11 days ago
@mpdesouza @monsieuricon I guess you want to send all replies at once? Indeed 'hkml' has no good feature for such things. I do such kind of batched replying with below workaround.

After writing a reply, 'hkml' asks you if you really want to send it, or not. If you say no, 'hkml' will ask you if you want to save and tag it as 'drafts'. In the case, if you try to reply to the mail again, 'hkml' finds the draft reply and ask you if you want to continue writing the draft. You can also list all drafts using 'hkml list drafts' and continue writing it, using the menu.

So when I want to review all patches and then send all comments at once, I save my drafts for each patch, and iterate multiple times on each draft for adding more comments on the drafts. Once I think all replies are ready to go, I send those one by one, but with no more draft updates.

Maybe I can add a new hkml feature for sending all drafts for a given thread at once.

#hkml
0
0
2
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: