Conor Dooley
Posts
464Following
144Followers
150I like cycling, powerlifting, bad video games and metal.
Otherwise, I occupy my time with various bits in RISC-V land.
~useless, placeholder, website: https://www.conchuod.ie/
Conor Dooley
conor
Edited 1 year ago
https://social.kernel.org/notice/AUYMfmHof5yHSkpLJA
Huh, so I finally figured out tonight why this was happening (and it was bothering me for months with false positives) but the attached pushed me to actually fix it.
The script in Linux to generate compile_commands.json takes a few arguments. There's a positional one:
"paths
directories to search or files to parse (files should be *.o, *.a, or modules.order). If nothing is specified, the current directory is searched"
and an optional one:
"-d DIRECTORY, --directory DIRECTORY
specify the output directory used for the kernel build (defaults to the working directory)"
Turns out that passing the build directory as one of the positional arguments is a no-go, as it will *mostly* work, but not pick up things like the kernels types (u32 etc) nor be able to use the symbols defined from Kconfig.
Instead, shoulda been passing it as --directory...
Call me biased, but perhaps the help text is not clear enough given doing it wrong "almost" works!
Huh, so I finally figured out tonight why this was happening (and it was bothering me for months with false positives) but the attached pushed me to actually fix it.
The script in Linux to generate compile_commands.json takes a few arguments. There's a positional one:
"paths
directories to search or files to parse (files should be *.o, *.a, or modules.order). If nothing is specified, the current directory is searched"
and an optional one:
"-d DIRECTORY, --directory DIRECTORY
specify the output directory used for the kernel build (defaults to the working directory)"
Turns out that passing the build directory as one of the positional arguments is a no-go, as it will *mostly* work, but not pick up things like the kernels types (u32 etc) nor be able to use the symbols defined from Kconfig.
Instead, shoulda been passing it as --directory...
Call me biased, but perhaps the help text is not clear enough given doing it wrong "almost" works!
1
0
2
Conor Dooley
conor
I love clangd, but man is it annoyingly wrong some times. My OCD really really hates this one:
1
0
0
Conor Dooley
conor
It's bad enough to fail a lift at the gym and be annoyed with yourself, only to turn around and realise people were watching you :/
0
0
0
@kernellogger No? There's refactoring/cleanup, moving to a different API or switching from some arch-specific implementation to one that is generic.
Those are "safe" to revert in comparison as there may not be someone that has gained a dependency on that feature that reverting it in a previous release would break.
Those are "safe" to revert in comparison as there may not be someone that has gained a dependency on that feature that reverting it in a previous release would break.
1
0
0
@kernellogger I don't quite follow. They're opposed to reverting a new feature or some other sort of change?
I can understand not wanting to revert the addition of a feature that landed a release ago.
What you do here totally depends on the regression and it's cause & without that context it's hard to agree/disagree.
I can understand not wanting to revert the addition of a feature that landed a release ago.
What you do here totally depends on the regression and it's cause & without that context it's hard to agree/disagree.
1
0
0
Conor Dooley
conor
@kernellogger not sure what to think of new Closes: trailer business. On one hand, the automation is nice to have but it just reeks of something that's gonna be used inconsistently.
1
0
1
Conor Dooley
conor
Wild bugbot appears!
https://lore.kernel.org/all/20230330-b217267c0-15b9c837ad2e@bugzilla.kernel.org/
https://lore.kernel.org/all/20230330-b217267c0-15b9c837ad2e@bugzilla.kernel.org/
0
0
3
@nathanchance @brauner @horms @gregkh @monsieuricon I was talking about branch descriptions, and format-patch's --cover-from-description argument. I don't doubt that b4 is easier though.
0
0
1
Conor Dooley
conor
Since there's no quote-rt here: https://fosstodon.org/@nathanchance/110113218822882839
Speaking of workflow, I need to figure out a workflow for auto-generating "do change x in 40 different places as 40 commits".
Speaking of workflow, I need to figure out a workflow for auto-generating "do change x in 40 different places as 40 commits".
0
0
1
@nathanchance @gregkh @brauner @horms @monsieuricon "you can embed the recipients of the series/patch into the cover letter once" to be fair, you can do this using git alone.
Been putting off using b4 for sending, I kinda wanna see what someone's workflow looks like before switching.
Been putting off using b4 for sending, I kinda wanna see what someone's workflow looks like before switching.
2
0
1
@ljs it's not been that cold this winter actually - but one of the worst bits is where they've removed road markings, leaving the tiniest of ruts. Over the course of the winter freeze/thaw and the traffic converted a barely noticeable bit of damage into quite a deep crack. It's become like cycling over a tramline, need to be very careful on a bike with slim tyres!
1
0
2
Conor Dooley
conor
Edited 1 year ago
A cross city infrastructure project means each day brings new damage to the road surface, some bits look up to 10 cm deep.
If I wanted to roll the dice on serious injury or death, I'd commute on my track bike..
If I wanted to roll the dice on serious injury or death, I'd commute on my track bike..
1
0
1
@brauner @gregkh @monsieuricon Aye, the b4 ones are rather nice. Certainly nicer than what you get out of git send-email, or god forbid, gmail.
0
0
0