Pavel Machek
Posts
2157Following
96Followers
198
Pavel Machek
pavel
@rmader Well... the thread began with "more than tuning is needed", and this is decision which will lead to redesign later. We'll likely want to use same tuning for gpuISP and then for hq-still-photo-component, and hq-still-photo-component does not exist at the moment :-).
And "why not use gpuISP at the moment". Well, besides quality, gpuISP only has one output. We need that output for preview. And that means we have photos in BAYER.
Being able to feed libcamera with BAYER data, and saying "Librem 5 back camera took this BAYER, please convert it to RGB in high quality" would be good.
And "why not use gpuISP at the moment". Well, besides quality, gpuISP only has one output. We need that output for preview. And that means we have photos in BAYER.
Being able to feed libcamera with BAYER data, and saying "Librem 5 back camera took this BAYER, please convert it to RGB in high quality" would be good.
1
0
0
Pavel Machek
pavel
@rmader 6. Yep. I can get 500x350 with gpuisp outputting RGB data on Librem 5. That's ... a bit low resolution. With YUY2, I can get 1000x700.
Anyway, I'm eagerly waiting for gpuISP and autofocus to hit the libcamera tree. [But one is at v10 now, and second I'm not sure what status of focus is, so my guess is that it will take few more months.]
Anyway, I'm eagerly waiting for gpuISP and autofocus to hit the libcamera tree. [But one is at v10 now, and second I'm not sure what status of focus is, so my guess is that it will take few more months.]
0
0
0
Pavel Machek
pavel
@rmader @dubstar_04 This is video from Clicks Machine . That's GPU processing pretty much tailored for Librem 5. Now I'm playing with libcamera, but it will be tricky to get 1000x750 recording with generic code code (such as libcamera).
0
0
2
Pavel Machek
pavel
@rmader 3. Lets take about this one, because I don't believe it is as simple as "just start Snapshot".
Gpuisp will need to include sensor tuning, correct? It is needed for video capture. And for still image capture, we'll need to capture full-size raw image, bypassing gpuisp, correct? That will get us bayer image.
But now we'll need to transform that bayer image into high-quality jpg. What is the proposal to do that?
Anyway I'm playing with libcamera-based photo taking here -- https://gitlab.com/tui/libcamera/-/commit/7c3c0d04c026d3a4a030fb7882095c028cd4ee8e -- but there's a lot of work to be done :-(.
Gpuisp will need to include sensor tuning, correct? It is needed for video capture. And for still image capture, we'll need to capture full-size raw image, bypassing gpuisp, correct? That will get us bayer image.
But now we'll need to transform that bayer image into high-quality jpg. What is the proposal to do that?
Anyway I'm playing with libcamera-based photo taking here -- https://gitlab.com/tui/libcamera/-/commit/7c3c0d04c026d3a4a030fb7882095c028cd4ee8e -- but there's a lot of work to be done :-(.
1
0
1
Pavel Machek
pavel
@rmader 1. Agreed. 2. Well... more work is needed, like actually merging the stuff in, right? And then we'll have to do _tuning_ of the AF algorithm. And probably someone needs to do PDAF. I tried in clicks machine, but again, more is missing than tuning. 3. "Missing few features" as in "will need complete redesign"? :-). This will get longer reply. 4. Agreed. Another missing piece. I'm eagerly waiting for gpuisp to hit the tree, but it is not there yet. 5. Ok, I was not aware of this one, it is good to see progress. (But again, more than tuning is needed). 6. Good to see that. Does gpuisp already do lens shading correction? That one is a bit important. Plus it should really output YUY2, because that's what encoder needs. Plus there's more work there, for example we'd want controls for manual focus, manual exposure; plus it needs to resize and not crop. But that's all work that should happen after it hits the tree.
Thanks for video. I guess we can agree that it needs working AF first, and then we'll see what else is needed? :-).
Thanks for video. I guess we can agree that it needs working AF first, and then we'll see what else is needed? :-).
1
0
1
Pavel Machek
pavel
@dubstar_04 @jbowen Yeah, Librem 5 is probably best hw for camera development at the moment. It has ... other issues. Take a look here: https://gitlab.com/tui/tui/-/tree/master/ccam?ref_type=heads
0
0
1
Pavel Machek
pavel
@dubstar_04 @jbowen Camera _sensors_ drivers are working on few models, yes. (Like 4 models). And of course you have talks. But as I said, what is missing is much _much_ more than tuning. AF is one example. Drivers for ISP and hardware encoders, libcamera based application stack for taking photos, and anything at all to record video.
Then we can do libcamera based video recording, and then.... probably hw acceleration for encoding and then...
Then we can do tuning.
Then we can do libcamera based video recording, and then.... probably hw acceleration for encoding and then...
Then we can do tuning.
2
1
3
Pavel Machek
pavel
@dubstar_04 @jbowen
#linuxmobile "Camera tuning" ? No sir, we are not doing camera tuning at the moment. We are in "it would be cool to have camera drivers", "major pieces of infrastructure are missing" and "oh, people would like to record video?" phases.
For "boring phone", OnePlus 6 + phosh should work.
And yes, people are working on cameras (including me, we can talk at Fosdem), but we are not yet in the tuning phase.
#linuxmobile "Camera tuning" ? No sir, we are not doing camera tuning at the moment. We are in "it would be cool to have camera drivers", "major pieces of infrastructure are missing" and "oh, people would like to record video?" phases.
For "boring phone", OnePlus 6 + phosh should work.
And yes, people are working on cameras (including me, we can talk at Fosdem), but we are not yet in the tuning phase.
1
1
5
Pavel Machek
pavel
I have Samsung S4 Mini (i9195) running close to mainline 6.19. Good. It took me more debugging that it should.
I also have patches that allowed me to trace execution from assembly to init/main.c to pagetable setup in C, using pixels on framebuffer and then with hacked console.
I also have patches that allowed me to trace execution from assembly to init/main.c to pagetable setup in C, using pixels on framebuffer and then with hacked console.
1
1
15
Pavel Machek
pavel
Asi je dobre ze je ten zlocinec zavrenej. Ale vzbuzuje to par otazek: Odkdy je trestny byt manzelkou zlocince? Co ty mimosoudni popravy a utoky na trosecniky, co k tomu vedly? Znamena to, ze kdyz je ted nekdo podezrelej, muze k nemu proste vtrhnout komando z jiny zeme?
Celej svet ma jasny dukazy, ze Trump + jeho oramada spachala valecny zlociny. Poslem komando?
Peter Novotny psal na Válka na Ukrajině
Madura a jeho manželku zajali americké jednotky a odviedli z krajiny.
Celej svet ma jasny dukazy, ze Trump + jeho oramada spachala valecny zlociny. Poslem komando?
Peter Novotny psal na Válka na Ukrajině
Madura a jeho manželku zajali americké jednotky a odviedli z krajiny.
2
1
4
Pavel Machek
pavel
@Logical_Error I'm fine; it is not a brick, I just overwrote my data. Only been using phone for a week, so not that much harm...
0
0
2