Conversation
krzk

Krzysztof Kozlowski

In a perfect world, I would have enough of time and energy to give every patch submitter personalized review, with a touch and nice words. I remember the times when I got one patch per week for my subsystem. Now, with like 600 patches and replies to me per week, I cannot. Reviewers are scarce and day has only 24h.

Unfortunately many issues are the same and do not require me, but ChatGPT. I figured out solution for all such trivialities: review templates.

But now, it's the second time submitter felt offended that I gave too obvious advice for an issue. What to do then? I will not write hundred times "please run checkpatch.pl", it's just waste of my time.
3
0
4
krzk

Krzysztof Kozlowski

Reply to @krzk
0
6
9
conor

Conor Dooley

Reply to @krzk
@krzk I think you probably guessed correctly in the thread, and it is a bit of feeling patronised. The various bot-like replies do seem a bit impersonal, but if you are experienced enough to feel patronised, you're experienced enough to understand why the bot-like/form-letters are required.
2
0
2
ljs

Lorenzo Stoakes

Reply to @conor
@conor @krzk I mechanically always run checkpatch.pl out of fear of humiliation on something silly. Hard to conceive of not doing that, though of course I've managed to make mistakes in every other axis :)

Maintainer scalability is hard.
1
0
1
krzk

Krzysztof Kozlowski

Reply to @conor
@conor Indeed. I refurbished a bit my templates and added more personal-like-phrases. Maybe I need to work on them a bit more... But I am also not a native English speaker, so I don't know how to exactly write a really nice message which will be kind but not exaggerated, so silly. I bet if I write "Please be so kind and use scripts/checkpatch.pl." there will be a person who will feel mocked by this.
1
0
1
krzk

Krzysztof Kozlowski

Reply to @ljs
@ljs @conor That's a good habit, I have the same, but we still can forget it from time to time. The point is not to be offended when someone tells me to compile the code or to run checkpatch.pl.
1
0
1
ljs

Lorenzo Stoakes

Reply to @krzk
@krzk @conor it's very hard to convey tone and to account for people's feelings when something seems like a reprimand, I think the kernel can be especially brutal.

I've been on both sides (though as a junior contributor, less so on the giving), but certainly with day job have had plenty of experience and I do find adding a little bit of nicey-nicey language around these things can make a decent difference.

Relating to the problem 'I know I've personally done [X] a thousand times too :)' like comments etc.

It's hard to get it right and under maintainer pressure I imagine a huge pain in the arse.
0
0
0
conor

Conor Dooley

Reply to @krzk
@krzk I think, at least among aware native speaks, it's accepted that non-natives often come across more bluntly.
And yeah, no matter how you work the form-letter, there is someone that will be put out because of it.
0
0
2
sj

sj

Reply to @krzk
@krzk I think adding maintainer profile[1] and using 'Submit Checklist Addendum' for the suggestion could also be used. I'm unsure how many people will read and follow it, but I think having such a public recommendation would not make something worse.

[1] https://docs.kernel.org/maintainer/maintainer-entry-profile.html
1
0
1
krzk

Krzysztof Kozlowski

Reply to @sj
@sj Unfortunately people in general: don't run checkpatch, don't read Submitting Patches doc, don't read other relevant docs, don't build test on many setups, don't test patches (in case of DT bindings). Sure, I can add one more doc for them to ignore :)
0
0
2
About social.kernel.org

Terms of service

  1. Please do not use this service in violation of the Linux Kernel Code of Conduct. Doing so will result in your account suspension with the referral of the matter to the CoC committee.

  2. "Repeating"/"boosting" someone else's status on this platform will be treated as endorsement and will fall under rule #1.

  3. You are encouraged to use this platform to promote your work on the Linux Kernel, but there is no restriction on permitted topics (with the exception of anything covered by #1 above).

  4. There is no requirement to post in English, but it should be considered the primary language of communication on this platform.

Privacy notice

The admins of this service have access to all posted statuses. They aren't looking, but if it's something they shouldn't know about, then you should not post it on this platform.

Please see the Linux Foundation Privacy Policy, which applies to this platform as well.

Getting your own account

If you would like an account on this instance, please check that the following applies to you:

  • You are listed in MAINTAINERS or CREDITS

  • OR: You have a kernel.org account or email address

  • OR: You have a long and established history of involvement with the Linux Kernel

If the above is true and you agree with the Terms of Service and Privacy Notice listed above, please use these instructions to request an account: