Posts
191
Following
31
Followers
191
Linux Kernel developer and maintainer
🇵🇱 🇪🇺 🇰🇷 🇮🇱 🇺🇦 🇨🇭
IRC: krzk
Kernel work related account. Other accounts of mine: @krzk@mastodon.social

Krzysztof Kozlowski

Edited 1 year ago
@kernellogger Been there. Request to backport few KVM patches for new AMD processors to distro v4.15 kernel resulted in 500-big patch bomb... and I was only half way. Then we gave up and managed to convince customer that it's not a feasible solution.
1
0
6

Krzysztof Kozlowski

Edited 1 year ago
Room full of people - I certainly didn't expect such big audience. #eoss2023 #elce2023 #EmbeddedOSSummit
1
0
7

Krzysztof Kozlowski

Edited 1 year ago
@kernellogger @mupuf the forges are not the answer. We already have tools which report such failures (LKP/kernel test robot), so either the tree was not on kernel.org (thus not covered by LKP by default) or reported warning was ignored.
What we maybe miss is a tool or part of workflow, which will check for how long patch was in next, before sending to Linus. And loudly complaining if it's less than two weeks.
1
0
0

Krzysztof Kozlowski

Edited 1 year ago
@pdp7 not bad shot. Looks like I'm swallowing something, maybe a comment about non-tested bindings :)
1
0
3
@monsieuricon xkcd nicely pointed out silliness of usual password approaches - difficult for us to remember, easy for machines to break: https://xkcd.com/936
0
0
0

Krzysztof Kozlowski

Updating my CV, collecting references, debt register extract, salary details and writing motivation letter. People do crazy stuff to get a nice apartment in Switzerland.
1
0
1
I would also dare to add â‚¿ (BTC) to above equations for greater impact. Let's think big! :)
0
0
2

Krzysztof Kozlowski

I love it. And think how many other equations and laws of physics can be improved with adding AI. Ohm's law? Dude, please, I = (V + AI) / R. Newton's second law? Easy peasy, F = m * a * AI. Maxwell equations - don't get me even started...
2
0
3

Krzysztof Kozlowski

Edited 1 year ago
@conor no, it was sent only to me, not to public lists, for some reason. And I don't know the license now. Is it GPL?
The code looks like a very good template, with comments what has to be added and checked to match real DTS.
0
0
0

Krzysztof Kozlowski

> [2]: Snippet created with the assisstance of GPT-4

So it began...

That was quite nice Devicetree source snippet. Can be entirely incorrect though, just looks good.
1
0
2

Krzysztof Kozlowski

Some useful commands for daily usage of DT schema helpful in efficient checking of the DTS files:
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
0
4
5
@sj Unfortunately people in general: don't run checkpatch, don't read Submitting Patches doc, don't read other relevant docs, don't build test on many setups, don't test patches (in case of DT bindings). Sure, I can add one more doc for them to ignore :)
0
0
2
@ljs @conor That's a good habit, I have the same, but we still can forget it from time to time. The point is not to be offended when someone tells me to compile the code or to run checkpatch.pl.
1
0
1
@conor Indeed. I refurbished a bit my templates and added more personal-like-phrases. Maybe I need to work on them a bit more... But I am also not a native English speaker, so I don't know how to exactly write a really nice message which will be kind but not exaggerated, so silly. I bet if I write "Please be so kind and use scripts/checkpatch.pl." there will be a person who will feel mocked by this.
1
0
1

Krzysztof Kozlowski

In a perfect world, I would have enough of time and energy to give every patch submitter personalized review, with a touch and nice words. I remember the times when I got one patch per week for my subsystem. Now, with like 600 patches and replies to me per week, I cannot. Reviewers are scarce and day has only 24h.

Unfortunately many issues are the same and do not require me, but ChatGPT. I figured out solution for all such trivialities: review templates.

But now, it's the second time submitter felt offended that I gave too obvious advice for an issue. What to do then? I will not write hundred times "please run checkpatch.pl", it's just waste of my time.
3
0
4

Krzysztof Kozlowski

Edited 1 year ago
@klausman @kernellogger The commit pointed by bisect might not be the real cause. Issue can be triggered by enabling via CONFIG change or just be interacting with something else. What now? Investigate the commit. It might tell you next steps...
Another solution could be to do second bisect - which second commit brought the issue when testing without the first one (then just remember to mark with git bisect good/bad proper commits).
1
1
2

Krzysztof Kozlowski

Edited 1 year ago
The first pancake is always spoiled? https://lore.kernel.org/linux-devicetree/20230511105006.176979-1-krzysztof.kozlowski@linaro.org/

BTW, above proverb in Polish is a bit more drastic: "Pierwsze koty za płoty", so literally: "The first cats over the fence". :)
0
0
6

Krzysztof Kozlowski

My bedroom has a view on few trees with three young squirrels, jumping, running and foraging every morning. I bet I would not have done any work there... Squirrels are too addictive.
0
0
2
This is a regular reminder that Russian military is still dropping high-yield explosives onto Ukrainian homes, killing women and children.

This is not f'n okay.
1
11
16
Show older